Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent reimporting album if an album is permanently removed from Spotify #4801

Merged
merged 3 commits into from
May 26, 2023
Merged

Prevent reimporting album if an album is permanently removed from Spotify #4801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0e3a53
Update spotify.py
arsaboo May 25, 2023
fa822d6
Add a check for valid data
arsaboo May 25, 2023
1ed41d3
Update changelog.rst
arsaboo May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions beetsplug/spotify.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,9 @@ def album_for_id(self, album_id):
album_data = self._handle_response(
requests.get, self.album_url + spotify_id
)
if album_data['name'] == "":
self._log.debug("Album removed from Spotify: {}", album_id)
return None
artist, artist_id = self.get_artist(album_data['artists'])

date_parts = [
Expand Down
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ for Python 3.6).

New features:

* Prevent reimporting album if it is permanently removed from Spotify
:bug:`4800`
* Added option use `cover_art_arl` as an album art source in the `fetchart` plugin.
:bug:`4707`
* :doc:`/plugins/fetchart`: The plugin can now get album art from `spotify`.
Expand Down