Import additional fields from Deezer and add function to update rank #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsaboo
changed the title
sampsyo
reviewed
Jul 12, 2023
Comment on lines
+79
to
+82
| if 'error' in album_data: | ||
| self._log.debug(f"Error fetching album {album_id}: " | ||
| f"{album_data['error']['message']}") | ||
| return None |
There was a problem hiding this comment.
Cool; this seems like an important addition! Maybe it deserves its own changelog bullet point?
There was a problem hiding this comment.
Not sure if this is required, but added it anyways :)
| medium_index=track_data.get('track_position'), | ||
| data_source=self.data_source, | ||
| data_url=track_data['link'], | ||
| deezer_updated=time.time(), |
There was a problem hiding this comment.
I don't 100% see yet the need for this field… we only seem to be writing to it, never reading from it. Is it useful for some future functionality?
There was a problem hiding this comment.
Yes, it is useful to only update based on time elapsed. For example, update the tracks that have not been updated in the last 2 months. In the absence of this information, we will have to update all the tracks.
Co-authored-by: Adrian Sampson <adrian@radbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4841
Imports few other fields provided by Deezer.
In addition, I added a function
deezerupdatethat updates the rank information without going through the import process. The rank information is updated daily and users may want to refresh the rank information periodically.To Do
docs/to describe it.)docs/changelog.rstnear the top of the document.)