Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lyrics.rst #5111

Closed
wants to merge 1 commit into from
Closed

Conversation

swishyswoosh
Copy link

looks like this backend was replaced with musixmatch

Description

Fixes #X.

(...)

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

looks like this backend was replaced with musixmatch
@jackwilsdon
Copy link
Member

The defaults for 1.6.0 (the latest release) are google, musixmatch, genius and tekstowo:

SOURCES = ['google', 'musixmatch', 'genius', 'tekstowo']

This was correctly documented at the time: https://github.com/beetbox/beets/blob/v1.6.0/docs/plugins/lyrics.rst#configuration

Since 1.6.0, the new lrclib source has been added (in #4989) and musixmatch has been removed from the default list (in #4616). These changes aren't yet in a release but are present on master, so the documentation is correct.

You can also see the difference on the hosted documentation:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants