Add a quick check for MST Store Python install #5470
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
snejus
requested changes
Oct 20, 2024
beets/ui/__init__.py
Outdated
Comment on lines
1863
to
1868
| "error: beets is unable to use the Microsoft Store version of " | ||
| "Python. Please install Python from python.org." | ||
| ) | ||
| log.error( | ||
| "error: More details can be found here " | ||
| "https://beets.readthedocs.io/en/stable/guides/main.html" |
There was a problem hiding this comment.
Consider using a single log.error call:
Suggested change
| "error: beets is unable to use the Microsoft Store version of " | |
| "Python. Please install Python from python.org." | |
| ) | |
| log.error( | |
| "error: More details can be found here " | |
| "https://beets.readthedocs.io/en/stable/guides/main.html" | |
| "error: beets is unable to use the Microsoft Store version of " | |
| "Python. Please install Python from python.org. See " | |
| "https://beets.readthedocs.io/en/stable/guides/main.html." |
|
Apologies for not addressing this earlier - all looks good, just needs a rebase on latest master. |
snejus
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quick fix for #5467.
Checks if the path for python is under the windows store folder then error and point the user to the beets documentation.
Happy for feedback to improve, but thought it best to exit as early as possible.
To Do