Add support for releases with multiple versions of the same recording #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruippeixotog
force-pushed
the
issue-230
branch
from
84f8ad4
to
7c19679
Compare
sampsyo
added a commit
that referenced
this pull request
Aug 22, 2014
Add support for releases with multiple versions of the same recording
sampsyo
added a commit
that referenced
this pull request
Aug 22, 2014
Use a defaultdict for more idiomatic collection.
|
Awesome! Thanks for addressing this so quickly! 🚀 I made just one small change in the commit above to use a defaultdict for accumulating the per-MBID lists. |
|
No problem, it was an issue for me too and the fix was easy 😄 I'm not fluent in Python, I didn't know the existence of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #230.
Theoretically it should also bring a performance benefit when syncing full albums, as finding the mappings is now linear-time in complexity. It probably won't cause a big effect, though.