Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new list fields set by MusicBrainz Picard #60

Merged
merged 2 commits into from
Feb 21, 2022

Conversation

jeandeaual
Copy link
Contributor

Add support for:

  • albumtypes

    Parse secondary album types, like Parse secondary album types from MusicBrainz beets#2200 but from the file tags directly.

  • catalognums

    Releases with multiple CDs sometimes have multiple catalog numbers (for example this release).

  • languages

    A work on MusicBrainz can have multiple languages, and by using Use track relationships in Picard they get written to the files.

Until now, the values could be retrieved with a separator for ID3v2.3 tags, but not for Vorbis tags:

>>> f = MediaFile('test.mp3')
>>> f.albumtype
'album/audio drama'
>>> f = MediaFile('test.flac')
>>> f.albumtype
'album'

With this PR:

>>> f.albumtypes
['album', 'audio drama']
>>> f.albumtype
'album'

Add `albumtypes`, 'catalognums' and `languages`.
@sampsyo
Copy link
Member

sampsyo commented Feb 19, 2022

Awesome; thank you for adding these! This looks perfect!!

Do you think you could add a quick changelog entry under a new "v0.10.0" heading here?
https://github.com/beetbox/mediafile/blob/master/docs/index.rst#changelog

@jeandeaual
Copy link
Contributor Author

Do you think you could add a quick changelog entry under a new "v0.10.0" heading here? https://github.com/beetbox/mediafile/blob/master/docs/index.rst#changelog

Done!

@sampsyo
Copy link
Member

sampsyo commented Feb 21, 2022

Wahoo; looks excellent! Thank you again!

@sampsyo sampsyo merged commit 4f70ee8 into beetbox:master Feb 21, 2022
@jeandeaual jeandeaual deleted the new-list-fields branch February 21, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants