Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POPM (popularity meter) tag support #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmbannon
Copy link
Contributor

@jmbannon jmbannon commented Jul 24, 2024

POPM seems to be the standard tag used for ratings across many music apps. This PR adds support for this tag.

Closes #23

@jmbannon
Copy link
Contributor Author

Summoning @sampsyo @JOJ0 for a review 🙂

@JOJ0
Copy link
Member

JOJ0 commented Aug 3, 2024

Hi @jmbannon sorry for a little late reply. Basically I think it's about time this tag gets integrated in mediafile. Great!

maybe you can put as much context into the PR description as possible, for documentation purposes.
I'm actually not sure if this repo has it's own changelog and how it's documented, so my only idea is to put as much as possible in the PR's description. I know you linked to the issue, but maybe copy over everything that is really relevant/true/worth knowing about his change. Which programs use this tag (eg Traktor I read, what else?), link to the docs on id3.org and so on.

And then there is something @Wolkenarchitect mentioned which I don't entirely understand: #23 (comment)
Is that relevant? AFAIS you implemented a basic tag that is a an integer? Is that enough?

@JOJ0
Copy link
Member

JOJ0 commented Aug 3, 2024

Ah, found it, there actually is a changelog: https://mediafile.readthedocs.io/en/latest/#changelog
and this is the source: https://github.com/beetbox/mediafile/edit/master/docs/index.rst

But it seems like @sampsyo did additions to that log in the past when pushing out a release. So not sure if you should add to it within this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add custom field - ID3 Popularimeter
2 participants