This repository has been archived by the owner on May 31, 2020. It is now read-only.
Encoding json #577
Merged
Encoding json #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basic implementation of JSONEncoder - does not accept arguments on init basic implementation of encode - needs to be properly tested, there is some sort of bug while encoding booleans, no circular structure checking or error handing in general some simple tests - would be great to reduce boilerplate somehow
In order to allow JSONEncoder to accept keyword arguments there is now a dummy JSONEncoder function (not an actual ctor) that creates instances of JSONEncoder (like a factory). Most of arguments functionality is still lacking.
Most of the keyword arguments to JSONEncoder has been implemented. Still missing sort_keys, check_circular and ensure_ascii.
Refactor tests and module structure Implement ensure_ascii, check_circular, dump, dumps and iterencode
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native implementation of parts of
jsonmodule:json.dump,json.dumpsandjson.JSONEncoder.For the time being
iterencodemethod ofJSONEncoderreturns a length 1 list instead of a generator.JSONEncodershould be a class but instead is a factory function returningJSONEncoderobjects. That is because there is currently no way to pass keyword arguments to object constructors implemented in JavaScript.