This repository has been archived by the owner on May 31, 2020. It is now read-only.
[WIP] Runtime version checking #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version module provides utilites to compare Python's version identifiers
abonie
force-pushed
the
runtime_version_checking
branch
5 times, most recently
from
e1a15c2
to
1ae9217
Compare
abonie
force-pushed
the
runtime_version_checking
branch
from
1ae9217
to
749d184
Compare
freakboy3742
suggested changes
Sep 8, 2017
There was a problem hiding this comment.
What you've got here is a big improvement on the previous iteration - but I'm pretty sure it can be simpler still.
Python provides sys.hexversion as a way to encode this as a simple integer -
https://docs.python.org/3/c-api/apiabiversion.html#apiabiversion
AFAICT, we could just have a hexversion for the magic number, and then compare numerically.
freakboy3742
approved these changes
Sep 9, 2017
|
Oh, that was still WIP. I'll finish it in another PR ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #643 that provides runtime version checks that are easier to use and maintain
PR Checklist: