Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Summer of Code 2017 final submission #183

Merged
merged 2 commits into from
Aug 23, 2017
Merged

Conversation

abonie
Copy link
Contributor

@abonie abonie commented Aug 23, 2017

No description provided.

@abonie
Copy link
Contributor Author

abonie commented Aug 23, 2017

I may want to edit this if beeware/batavia#643 gets merged before deadline for final submissions :)

@phildini
Copy link
Member

This is totally reasonable as-is, and if you're happy with it we can move forward.
I'm going to leave some notes and suggestions for things you could improve if you wanted.


With Google Summer of Code 2017 program nearing its end, it is time to summarize what I got done during the summer working on `Batavia </project/projects/bridges/batavia/>`__.

Batavia is a part of Pybee's BeeWare collection of projects. I posted my proposal in `this GitHub thread <https://github.com/pybee/batavia/issues/483>`__ and kept it updated with my progress on a weekly basis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though people could click the link and read the proposal, it would be awesome to have a sentence or two of high-level summary of what you wanted to accomplish when you set out this summer.


Batavia is a part of Pybee's BeeWare collection of projects. I posted my proposal in `this GitHub thread <https://github.com/pybee/batavia/issues/483>`__ and kept it updated with my progress on a weekly basis.

Note that by the end of GSoC, we have decided to diverge from the proposal and forgo implementation of `contextlib` in favor of support for Python 3.6 2-byte wide opcodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the same vein as the above, it would great to have a sentence or two summary of what was accomplished, and then the links below become supporting evidence to that summary.


Note that by the end of GSoC, we have decided to diverge from the proposal and forgo implementation of `contextlib` in favor of support for Python 3.6 2-byte wide opcodes.

Overall it was great learning experience and fun. Big thanks to my mentors Russel Keith-Magee and Katie McLaughlin, and the whole Pybee community.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you had any take-aways, or surprising things learned while working on the project, I'd be super curious to hear about them and I'm sure others would as well. This might be a good place to add them, either before or after the thank-yous.


Pull Requests
=============
Lists and dicts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General thoughts on the list below: Adding a short description for each link (and making them real links) would be super helpful. The description could even be the PR title. The goal here is to give readers a sense of what was accomplished in each category.

@abonie
Copy link
Contributor Author

abonie commented Aug 23, 2017

Hey, thanks for your comments. I have made some changes, as much as I could before leaving town for few days tomorrow. I'll give it another look on Monday, but it would be great if this got merged by then, so I know I have something to show.

Copy link
Member

@phildini phildini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phildini phildini merged commit 78c7afe into beeware:lektor Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants