[1876] fix(cookiecutter): Adds XML quote and backslashes escape support #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesara
reviewed
Nov 26, 2024
| @@ -139,6 +139,11 @@ def bool_attr(obj): | |||
| """Render value in XML format appropriate for an attribute.""" | |||
| return "true" if obj else "false" | |||
|
|
|||
| def escape_xml(obj): | |||
| """Escapes single quotes and backslashes.""" | |||
| return obj.replace("\\", "\\\\").replace("'", "\\'") | |||
There was a problem hiding this comment.
May be best way to escape ' and " is using "'" or '"'.
To allow attribute values to contain both single and double quotes, the apostrophe or single-quote character
(')may be represented as" ' ", and the double-quote character(")as" " ".
See https://www.w3.org/TR/REC-xml/#syntax
There was a problem hiding this comment.
So best thing to do here might be replacing ' with '.
There was a problem hiding this comment.
Also https://docs.python.org/3/library/xml.sax.utils.html#xml.sax.saxutils.quoteattr might be of help.
|
Unneeded change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds XML quote and backslashes escape support
#1876
PR Checklist: