Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

Commit

Permalink
Merge pull request #52 from chrysn-pull-requests/actually-close-socket
Browse files Browse the repository at this point in the history
transports: Close socket when closing the transport
  • Loading branch information
freakboy3742 committed Feb 20, 2022
2 parents c534f08 + f2ac517 commit 51c3422
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ Bugfixes

* Corrected the import of ``InvalidStateError`` to fix an error seen on Python 3.8+. (`#56 <https://github.com/beeware/gbulb/issues/56>`__)

* Reverted the fix from #47; that change led to file descriptor leaks. (`#52 <https://github.com/beeware/gbulb/issues/52>`_)


0.6.2 (2021-10-24)
------------------
Expand Down
2 changes: 1 addition & 1 deletion src/gbulb/transports.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _force_close_async(self, exc):
self._protocol.connection_lost(exc)
finally:
if self._sock is not None:
self._sock.detach()
self._sock.close()
self._sock = None
if self._server is not None:
self._server._detach()
Expand Down

0 comments on commit 51c3422

Please sign in to comment.