-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest dependencies for Testbed testing #2652
Conversation
So, these changes in At any rate, once I was able to wrap my head around how any of this even works, there is where I landed. Fortunately, Toga's use of A potentially notable aspect of this approach stems from the fact that My Finally, in trying to understand the linux failures in CI (i.e #2648), I figured it was a good idea to get on the latest versions of everything first. |
- Recent versions of pytest-asyncio introduced a lot of breaking changes. Notably, a session-wide event loop can no longer be specified via the ``event_loop()`` fixture. However, an event loop policy can be specified via the ``event_loop_policy()`` fixture. - As such, this introduces a simple event loop policy that defers to the existing event loop proxy.
bc0904f
to
ee3d0d9
Compare
... My good sir, you are massively underselling your skill set here :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/me golf claps.
Nice work - both on the nice hack to get dependabot updating the testbed dependencies, and to get pytest-asyncio
up to date.
One minor suggestion to limit the scope of a dependency; but otherwise this looks great.
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
event_loop()
fixture. However, an event loop policy can be specified via theevent_loop_policy()
fixture.PR Checklist: