-
-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Wayland, run testbed on Ubuntu 24.04 #2893
Conversation
4314aab
to
f2f63bb
Compare
well, this is one option; it does require building a wheel for Pillow each time...but it works 😅 |
Ah- that's because we've pinned such an old version of Pillow. Upgrading the pinned Pillow version is on the todo list; Android wheels are the sticking point. In the meantime, a pillow build is annoying, but isn't that onerous - and it's a lot less annoying that having 50% of Toga CI runs fail. The other annoying inconsistency is that this means the GTK tests are running on 3.12, rather than 3.10 as they are for every other platform. My inclination is to roll back the linux-x11 change to stay on 22.04 for that reason - that also lets us avoid the Pillow build until we can bump the pinned version. It looks like there was a new version of mutter published in September, so the emergence of this problem looks like it could be consistent with that version update. |
- The version of mutter on Ubuntu 22.04 creates issues for the testbed; the version on Ubuntu 24.04 is newer and avoids the issues.
f2f63bb
to
32df575
Compare
Sounds good; I reverted the changes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to call this a win. Congrats on a nice bit of debugging.
pre-command: | | ||
sudo apt update -y | ||
sudo apt install -y --no-install-recommends \ | ||
mutter pkg-config python3-dev libgirepository1.0-dev libcairo2-dev \ | ||
gir1.2-webkit2-4.1 gir1.2-xapp-1.0 | ||
gir1.2-webkit2-4.1 gir1.2-xapp-1.0 \ | ||
libjpeg-dev # remove once the version of Pillow has a wheel on PyPI for Python 3.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmartin16 I came across this line just now and was wondering if the dependency can be removed now? At the time of this PR, Pillow was pinned to 9.2.0 in the testbed, but it's pinned to 11.00.00 now, which has 3.12 wheels on PyPI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - we should be able to remove this one now.
Changes
PR Checklist: