This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Add some issues #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,10 +5,15 @@ | |||
| */ | |||
| public class Foo { | |||
|
|
|||
| public int i; | |||
There was a problem hiding this comment.
Document this public field. 
Make i a static final constant or non-public and provide accessors if needed.
|
SonarQube analysis reported 3 issues
Watch the comments in this conversation to review them. |
| public static int div(int a, int b) { | ||
| if (b == 0) { | ||
| throw new UnsupportedOperationException("Can't divide by zero!"); | ||
| } | ||
|
|
||
| System.out.println("foo"); |
There was a problem hiding this comment.
Replace this usage of System.out or System.err by a logger.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.