BEMHTML: fix position with replace() #395

miripiruni · 2016-12-10T12:59:22Z

Fixes #394

miripiruni · 2016-12-10T13:02:45Z

lib/bemxjst/tree.js

@@ -80,12 +80,13 @@ ReplaceMatch.prototype.wrapBody = function wrapBody(body) {

  if (typeof body !== 'function') {
    return function inlineAdaptor() {
-      return applyCtx(body);
+      return applyCtx(body, { position: this.position - 1 });


JFIY: applyCtx() запускает новую волну _run(). Но в BEMContext-е остаётся position, который уже был инкрементирован. Соотстветственно _run() инкрементирует position еще раз, чего не нужно делать.

добавь этот комментарий прямо в код ;-)

coveralls · 2016-12-10T13:24:10Z

Coverage remained the same at 97.041% when pulling b32094e on replace-position__issue-394 into e3221e9 on master.

veged · 2016-12-12T07:46:16Z

LGTM

BEMHTML: fix position with replace() (#394 fixed)

eaa2728

miripiruni added semver: patch status: review type: bug labels Dec 10, 2016

miripiruni commented Dec 10, 2016

View reviewed changes

tadatuta approved these changes Dec 10, 2016

View reviewed changes

Test: position with appendContent()/prependContent()

b32094e

miripiruni added this to the 8.5.1. milestone Dec 12, 2016

miripiruni merged commit 71cca07 into master Dec 12, 2016

miripiruni deleted the replace-position__issue-394 branch December 12, 2016 09:08

miripiruni removed the status: review label Dec 12, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BEMHTML: fix position with replace() #395

BEMHTML: fix position with replace() #395

miripiruni commented Dec 10, 2016

miripiruni Dec 10, 2016 •

edited

Loading

veged Dec 12, 2016

coveralls commented Dec 10, 2016 •

edited

Loading

veged commented Dec 12, 2016

BEMHTML: fix position with replace() #395

BEMHTML: fix position with replace() #395

Conversation

miripiruni commented Dec 10, 2016

miripiruni Dec 10, 2016 • edited Loading

Choose a reason for hiding this comment

veged Dec 12, 2016

Choose a reason for hiding this comment

coveralls commented Dec 10, 2016 • edited Loading

veged commented Dec 12, 2016

miripiruni Dec 10, 2016 •

edited

Loading

coveralls commented Dec 10, 2016 •

edited

Loading