Skip to content

Commit

Permalink
Don't fail hard on invalid environment variable values.
Browse files Browse the repository at this point in the history
Also, only log overrides that succeed.
  • Loading branch information
bemasher committed Oct 7, 2016
1 parent 914fe8d commit bf6b099
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,13 @@ func EnvOverride() {
envName := "RTLAMR_" + strings.ToUpper(f.Name)
flagValue := os.Getenv(envName)
if flagValue != "" {
log.Printf("Environment variable %q overrides flag %q with %q\n", envName, f.Name, flagValue)
if err := flag.Set(f.Name, flagValue); err != nil {
log.Fatalf(
log.Printf(
"Environment variable %q failed to override flag %q with value %q: %q\n",
envName, f.Name, flagValue, err,
)
} else {
log.Printf("Environment variable %q overrides flag %q with %q\n", envName, f.Name, flagValue)
}
}
})
Expand Down

0 comments on commit bf6b099

Please sign in to comment.