Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail test on missing/new snapshot #26

Closed
alexhornbake opened this issue Oct 16, 2017 · 0 comments
Closed

Fail test on missing/new snapshot #26

alexhornbake opened this issue Oct 16, 2017 · 0 comments
Assignees
@alexhornbake
Labels
enhancement

Comments

@alexhornbake
Copy link
Contributor

Pairing with @colinmcardell and explaining the how/why of snapshots it occured to me that it would be really helpful that default case should be a failure.

If no snapshot exists, treat the snapshot as "" such that the new response is logged. Do not capture a snapshot until the user explicitly runs -- -u
@alexhornbake alexhornbake changed the title First Snapshot should fail tests Fail test on missing/new snapshot Oct 16, 2017
sjkaliski added a commit that referenced this issue Oct 21, 2017
@sjkaliski
Merge pull request #28 from beme/sjkaliski-fail-on-new-snapshot
86adc0a 
fail test when new snapshot identified, closes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexhornbake alexhornbake

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sjkaliski @alexhornbake