Fix issue where player cannot touch below canvas to activate note #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtinth
commented
Mar 10, 2018
| @@ -65,22 +65,21 @@ export class Context { | |||
| let onTouch = e => { | |||
| touches = [].slice.call(e.touches) | |||
| } | |||
| let view = this.view | |||
There was a problem hiding this comment.
To fix the test, can allow specifying an option, touchEventTarget in Context constructor. If not found, defaults to this.view.
dtinth
changed the title
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 80.86% 80.86% +<.01%
==========================================
Files 156 156
Lines 4760 4761 +1
Branches 184 184
==========================================
+ Hits 3849 3850 +1
Misses 862 862
Partials 49 49
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on user testing!
Changelog
Fixed an issue where a player, when playing using a touch screen in 3D mode, cannot touch below canvas to activate the note.