-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Browserslist compatibility table #483
Conversation
https://jamie.build/last-2-versions A usage-based compatibility table would be better for browserslist. I've also moved the `browserslist` option to `package.json` so that all packages that depend on it (e.g. Babel) could use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!! Thanks for updating this settings.
However, I found that the compiled code still have arrow functions and classes transpiled. But I think it is better this way, for now.
We also have a list of supported browsers here, which we may be able to use as a basis for future browsers list: https://github.com/bemusic/bemuse/blob/master/src/app/browser-support.js The problem is that, if older browsers sees a modern syntax, the game will not start, and will not even display a “cannot load app” or “browser unsupported” error.
So I suggest using the one in this PR for now. Maybe in the future we can update the browserslist more aggressively if we have proper way to check browser support. Please feel free to merge this! 😄
Thanks!!
I'm also in the middle of implementing <
https://www.npmjs.com/package/browserslist-useragent>, which will check the
browsers' useragent against the configured browserslist. We should also be
able to derive the browsers' compatibility table from said list.
I'll take a flight back home soon, but I'll be able to look into it once
I'm down on the ground. :)
…On Mon, 14 May 2018, 00:36 Thai Pangsakulyanont, ***@***.***> wrote:
***@***.**** approved this pull request.
This looks great!! Thanks for updating this settings.
However, I found that the compiled code still have arrow functions and
classes transpiled. But I think it is better this way, for now.
We also have a list of supported browsers here, which we may be able to
use as a basis for future browsers list:
https://github.com/bemusic/bemuse/blob/master/src/app/browser-support.js
The problem is that, if older browsers sees a modern syntax, the game will
not start, and will not even display a “cannot load app” or “browser
unsupported” error.
So I suggest using the one in this PR for now. Maybe in the future we can
update the browserslist more aggressively if we have proper way to check
browser support. Please feel free to merge this! 😄
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#483 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFZshangcgcO8NZHvKazr5rMmGD81kd-ks5tyG8OgaJpZM4T5iQc>
.
|
@dtinth Okay, I just arrived back home. For now I can merge this. I'll look into applying browser version check based on the passed browserslist string on a separate PR. Thanks! |
As mentioned on this blog post, a usage-based compatibility table has a better representation and would prevent tools like Autoprefixer from unnecessarily compiling away things.
I've also moved the
browserslist
option topackage.json
so thatall packages that depend on it (e.g. Babel) could use it.
See browserslist coverage