Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Browserslist compatibility table #483

Merged
merged 3 commits into from
May 18, 2018
Merged

Conversation

resir014
Copy link
Member

@resir014 resir014 commented May 10, 2018

As mentioned on this blog post, a usage-based compatibility table has a better representation and would prevent tools like Autoprefixer from unnecessarily compiling away things.

I've also moved the browserslist option to package.json so that
all packages that depend on it (e.g. Babel) could use it.

See browserslist coverage

https://jamie.build/last-2-versions

A usage-based compatibility table would be better for browserslist.

I've also moved the `browserslist` option to `package.json` so that
all packages that depend on it (e.g. Babel) could use it.
@resir014 resir014 requested a review from dtinth May 10, 2018 08:20
Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! Thanks for updating this settings.

However, I found that the compiled code still have arrow functions and classes transpiled. But I think it is better this way, for now.

We also have a list of supported browsers here, which we may be able to use as a basis for future browsers list: https://github.com/bemusic/bemuse/blob/master/src/app/browser-support.js The problem is that, if older browsers sees a modern syntax, the game will not start, and will not even display a “cannot load app” or “browser unsupported” error.

So I suggest using the one in this PR for now. Maybe in the future we can update the browserslist more aggressively if we have proper way to check browser support. Please feel free to merge this! 😄

@resir014
Copy link
Member Author

resir014 commented May 13, 2018 via email

@resir014
Copy link
Member Author

resir014 commented May 14, 2018

@dtinth Okay, I just arrived back home. For now I can merge this. I'll look into applying browser version check based on the passed browserslist string on a separate PR.

Thanks!

@resir014 resir014 merged commit b48ef13 into master May 18, 2018
@resir014 resir014 deleted the browserslist-updates branch October 3, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants