-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade Docusaurus + Docs rearranging #489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 170 170
Lines 5370 5370
Branches 1 1
=======================================
Hits 4516 4516
Misses 854 854 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks a lot!! 👍
However, the part about combo bonus is missing from the docs. I added an example of how it affects the score in the comment below.
docs/scoring-and-judgment.md
Outdated
|
||
The player's score is calculated from this formula: | ||
Based on the above judgement, an accuracy score is given based on the above judgement out of a highest possible score of 555555. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part is inaccurate...
The final score is split into 2 parts:
- 500000 for accuracy
- 55555 for combo bonus
Each combo has an associated score.
Combo number | Combo score |
---|---|
0 | 0 |
1–22 | 1 |
23-50 | 2 |
51-91 | 3 |
92–160 | 4 |
161~∞ | 5 |
Combo bonus is the sum of combo score for each hit, divided by maximum possible value, times 55555.
Example: There are 100 notes. 60 notes have been hit, I missed a note, and hit 39 other notes.
- Obtained combo score = 108 for first 60 notes + 56 for 39 other notes = 164
- Maximum possible combo score = 237
- Combo bonus = 164 / 237 * 55555 = 38443
@dtinth Alright, fixed. I just realised I forgot to push the second page (which is Architecture) 😅 I just did so now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! Going to merge this 🎉🎉🎉
Updating Docusaurus as well as bringing more outdated docs up to date.