📝 music server docs improvements #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #511 +/- ##
======================================
Coverage 84.1% 84.1%
======================================
Files 171 171
Lines 5387 5387
Branches 1 1
======================================
Hits 4531 4531
Misses 856 856Continue to review full report at Codecov.
|
|
Preview page is here |
dtinth
reviewed
Nov 10, 2018
Co-Authored-By: CenoX <dev@cenox.co>
Since it is not officially supported yet...
Dropbox deprecated public folders long ago
dtinth
reviewed
Nov 11, 2018
docs/music-server.md
Outdated
| Then, create a symlink to enable the configured site: | ||
|
|
||
| ```bash | ||
| $ sudo ln -s /etc/nginx/site-available/bemuse site-enabled/bemuse |
There was a problem hiding this comment.
Are you sure it’s called site-available and site-enabled, and not sites-available and sites-enabled?
There was a problem hiding this comment.
Oh you right, it is site's' available and enabled. I'll commit changes.
📝 Fix typo of linux nginx folder. 📝 Fix typo of open command on linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Bemuse's pack feature is not supported properly by AAC codec on Linux, but still can pack and run. added prerequisites for linux.
📝 I experienced when install bemuse-tools via yarn can cause
no commanderror, added the way how export yarn path.📝 Current docs describe xampp-apache based local machine, so added nginx based way for macOS and Linux.