Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bms and bmson package TypeScripted #520

Merged
merged 12 commits into from
Dec 9, 2018
Merged

Make bms and bmson package TypeScripted #520

merged 12 commits into from
Dec 9, 2018

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Dec 9, 2018

This PR:

  • Creates a new base tsconfig, tsconfig.lib.json for TS-based libraries. Sub-projects should migrate to this base config (only libraries, not CLI tools, so e.g. bemuse-tools are exempt).

  • Migrates packages/bms to TypeScript.

  • Migrates packages/bmson to TypeScript.

@codecov-io
Copy link

codecov-io commented Dec 9, 2018

Codecov Report

Merging #520 into master will decrease coverage by 1.21%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #520      +/-   ##
==========================================
- Coverage   83.25%   82.04%   -1.22%     
==========================================
  Files         172      167       -5     
  Lines        5423     5129     -294     
  Branches        1       68      +67     
==========================================
- Hits         4515     4208     -307     
+ Misses        908      903       -5     
- Partials        0       18      +18
Impacted Files Coverage Δ
packages/bms/src/notes/channels.ts 100% <ø> (ø)
packages/bms/src/util/lodash.ts 100% <ø> (ø)
packages/bms/src/bms/chart.ts 100% <100%> (ø)
packages/bms/src/notes/note.ts 100% <100%> (ø)
packages/bms/src/util/match.ts 100% <100%> (ø)
packages/bms/src/bms/objects.ts 84.21% <100%> (ø)
...ges/bms/src/reader/getReaderOptionsFromFilename.ts 37.5% <100%> (ø)
packages/bms/src/bms/headers.ts 80% <100%> (ø)
packages/bms/src/time-signatures/index.ts 92.3% <100%> (ø)
packages/bms/src/notes/index.ts 94.11% <100%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dad7f6...7dfde80. Read the comment docs.

@dtinth dtinth changed the title Make bms package TypeScripted Make bms and bmson package TypeScripted Dec 9, 2018
@dtinth dtinth merged commit e28d6d4 into master Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants