-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bms and bmson package TypeScripted #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
- Coverage 83.25% 82.04% -1.22%
==========================================
Files 172 167 -5
Lines 5423 5129 -294
Branches 1 68 +67
==========================================
- Hits 4515 4208 -307
+ Misses 908 903 -5
- Partials 0 18 +18
Continue to review full report at Codecov.
|
dtinth
changed the title
Make bms package TypeScripted
Make bms and bmson package TypeScripted
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Creates a new base tsconfig,
tsconfig.lib.json
for TS-based libraries. Sub-projects should migrate to this base config (only libraries, not CLI tools, so e.g. bemuse-tools are exempt)..d.ts
files for consumers (until Allow--declaration
with--allowJs
microsoft/TypeScript#7546 is resolved)Migrates
packages/bms
to TypeScript.Migrates
packages/bmson
to TypeScript.