Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGG support!!!! (using stbvorbis.js) #534

Merged
merged 8 commits into from
Aug 28, 2019
Merged

OGG support!!!! (using stbvorbis.js) #534

merged 8 commits into from
Aug 28, 2019

Conversation

dtinth
Copy link
Member

@dtinth dtinth commented Aug 27, 2019

Closes #509

Thanks to @hajimehoshi’s stbvorbis.js, it works pretty well and now allows Bemuse to support OGG/Vorbis in iOS and Safari!

Changelog

OGG support is added to iOS and Safari, using [@hajimehoshi]’s stbvorbis.js library to decode OGG files in-browser. This means that Bemuse no longer relies on proprietary audio file format (m4a) to function in Safari and iOS, and thus:

  • Generating a Bemuse package is faster because m4a files no longer to be generated.

  • Less disk space requirement as only ogg files are needed.

  • A Bemuse package can now be generated on Linux, due to proprietary tools to use Apple’s m4a encoder is no longer needed.

With this change, creating content for Bemuse will become easier and more accessible!

@akibot
Copy link
Contributor

akibot commented Aug 27, 2019

Fails
🚫 src/sampling-master/vendor/stbvorbis/stbvorbis-e6da5fe.js is not formatted using Prettier.
Messages
📖

You can run yarn style:fix to automatically format all files using Prettier.

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #534 into master will decrease coverage by 0.72%.
The diff coverage is 14.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   81.38%   80.65%   -0.73%     
==========================================
  Files         153      154       +1     
  Lines        4619     4667      +48     
  Branches       68       68              
==========================================
+ Hits         3759     3764       +5     
- Misses        842      885      +43     
  Partials       18       18
Impacted Files Coverage Δ
src/sampling-master/ogg.js 4.87% <4.87%> (ø)
src/sampling-master/index.js 95.72% <83.33%> (-3.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb891f5...138f0d7. Read the comment docs.

release-train bot added a commit that referenced this pull request Aug 28, 2019
release-train bot added a commit that referenced this pull request Aug 28, 2019
release-train bot added a commit that referenced this pull request Aug 28, 2019
release-train bot added a commit that referenced this pull request Aug 28, 2019
release-train bot added a commit that referenced this pull request Aug 28, 2019
release-train bot added a commit that referenced this pull request Aug 28, 2019
release-train bot added a commit that referenced this pull request Aug 28, 2019
@dtinth dtinth merged commit 83dda1e into master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle an ogg/vorbis decoder for use in Safari/iOS
3 participants