-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGG support!!!! (using stbvorbis.js) #534
Conversation
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 81.38% 80.65% -0.73%
==========================================
Files 153 154 +1
Lines 4619 4667 +48
Branches 68 68
==========================================
+ Hits 3759 3764 +5
- Misses 842 885 +43
Partials 18 18
Continue to review full report at Codecov.
|
Closes #509
Thanks to @hajimehoshi’s stbvorbis.js, it works pretty well and now allows Bemuse to support OGG/Vorbis in iOS and Safari!
Changelog
OGG support is added to iOS and Safari, using [@hajimehoshi]’s stbvorbis.js library to decode OGG files in-browser. This means that Bemuse no longer relies on proprietary audio file format (m4a) to function in Safari and iOS, and thus:
Generating a Bemuse package is faster because m4a files no longer to be generated.
Less disk space requirement as only ogg files are needed.
A Bemuse package can now be generated on Linux, due to proprietary tools to use Apple’s m4a encoder is no longer needed.
With this change, creating content for Bemuse will become easier and more accessible!