Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove impure #814

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Remove impure #814

merged 4 commits into from
Jan 4, 2023

Conversation

MikuroXina
Copy link
Collaborator

Separated from #790.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Base: 95.54% // Head: 86.46% // Decreases project coverage by -9.07% ⚠️

Coverage data is based on head (4a0461c) compared to base (9c46e3a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #814      +/-   ##
==========================================
- Coverage   95.54%   86.46%   -9.08%     
==========================================
  Files          39      175     +136     
  Lines         673     5378    +4705     
  Branches       65      362     +297     
==========================================
+ Hits          643     4650    +4007     
- Misses         15      678     +663     
- Partials       15       50      +35     
Impacted Files Coverage Δ
bemuse/src/utils/read-blob.js 100.00% <0.00%> (ø)
bemuse/src/game/input/touch-plugin.spec.js 100.00% <0.00%> (ø)
bemuse/src/test/karma.js 100.00% <0.00%> (ø)
bemuse/src/custom-folder/index.spec.ts 93.54% <0.00%> (ø)
bemuse/src/music-collection/sortSongs.js 71.42% <0.00%> (ø)
bemuse/src/sampling-master/index.spec.js 96.12% <0.00%> (ø)
bemuse/src/custom-song-loader/index.spec.js 100.00% <0.00%> (ø)
bemuse/src/resources/bemuse-package.spec.js 100.00% <0.00%> (ø)
bemuse/src/test/loadSpecs.js 100.00% <0.00%> (ø)
bemuse/src/game/display/note-area.js 100.00% <0.00%> (ø)
... and 126 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dtinth dtinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made things much cleaner, thank you very much! 👍

@MikuroXina MikuroXina marked this pull request as ready for review January 4, 2023 10:35
@MikuroXina MikuroXina self-assigned this Jan 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dtinth dtinth merged commit de696f1 into bemusic:master Jan 4, 2023
@MikuroXina MikuroXina deleted the remove/impure branch January 4, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants