Optimize the entire program

[cloudcloudskies]

I tried to compile but got a bit long error, as I don't know how to fix..

[bemxio]

thank you for your contribution! although, could you please explain the optimizations in your code? i am certainly not a C++ expert but i'd like to know what i can use that you utilized to write better code!

from what i can see though, you implemented error handling, however could you please make it trigger the BSOD instead of exiting out? if the code can't get and play the video, it would be nice for it to at least do the bare minimum by crashing Windows
also please try to write comments, or at least adapt my previous ones to your new code

also, what does that | do in the Makefile? does it make a difference in how it handles stuff? i never saw that being used

[cloudcloudskies]

the | stands for and

[cloudcloudskies]

i did those:
proper resource management to avoid memory leaks
smart pointers (std::unique_ptr) for DirectShow interfaces to ensure automatic resource cleanup
simplified exception handling using try-catch block to catch and display any exceptions that might occur during DirectShow initialization or video playback.

[cloudcloudskies]

now bsod triggers when load failed

[bemxio]

i've made some comments, i tried to compile the current code and test it on Windows XP but gcc complained about TriggerBSOD being out-of-scope

[cloudcloudskies]

oh
can you fix it btw? im a lil busy

[bemxio]

sure, once i have some free time i can fix and clean up some stuff

[cloudcloudskies]

sure ty

[bemxio]

alright, i cleaned up the code, i had to remove the try-catch block because it actually caused issues, at least on Windows XP
check out stuff and tell me if it's ready to merge, i'll do that then and later on will create a new release

[cloudcloudskies]

i think its ready to merge

[bemxio]

alright then, thank you really much for your contribution! <3 it makes me happy to see someone get interested in my projects
have a nice day :)))

[cloudcloudskies]

no problem!