#1347 - Fix for hibernate.javax.cache.uri in JakartaEE EARs #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for loading specific configuration files from within EAR's jar files. Change-Id: I54bf4740bf9be3181795ce6ad39d112dd1a4d802
|
|
Move else-if up to better match the code flow Change-Id: I3323bc9619f1d38be10637fd67bff19cf9641c52
ben-manes
reviewed
Nov 30, 2023
...he/src/main/java/com/github/benmanes/caffeine/jcache/configuration/TypesafeConfigurator.java
Outdated
Show resolved
Hide resolved
Use ConfigFactory.parseURL for reading jar located config. Change-Id: I1a6603bc2973d71d07993ec352119639b11d5169
Propagate the MalformedURLException Change-Id: I3c832e71f8307facd50c8e10d6d2b65def300887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1347, the URIs in case of JakartaEE jar files are neither file: nor classpath: but jar:.
Extend the TypesafeConfigurator#resolveConfig to properly pass also jar: protocol URLs, so the Caffeine can be used as Hibernate's 2nd level cache in complex JakartaEE applications.