Some fixes (Time Datatype, parsing floats, crash when loading 2 files) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all: Sorry, I don't have time to really turn this into a proper PR at the moment.
I stumbled upon this library a few days back, because I needed to parse large (~10GB) VCD files containing reals. Several things didn't work as I hoped so I hacked them for my purposes. Also all these pointers (heap-allocation) makes the library quite slow, so I got rid of them - but it's not really a fix.
You probably want to cherry-pick the other commits though. For example flex crashes for the second file it tries to parse because the buffer was free'd in
scan_end.