Add apple silicon targets #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the danger check failing. It only works for contributors that can access this repo's default github token |
|
Might work if I manually rerun it though 🤞 |
|
Shoot okay. I'll need to make some CI updates this weekend—apologies |
|
@ychescale9 can you please update with master? CI no longer requires the GITHUB_TOKEN secret to run, so you should able to get a clean CI run (though upgrading ktlint may require running ktlintformat, in case there are new rules that need to be applied). |
ychescale9
force-pushed
the
yc/add-apple-silicon-targets
branch
from
ee6a8ae to
f3db4c0
Compare
|
Rebased. |
|
@ychescale9 landed some more fixes. Try rebasing one more time 🤞 |
ychescale9
force-pushed
the
yc/add-apple-silicon-targets
branch
from
f3db4c0 to
b3d2fd6
Compare
|
Done :) |
|
@ychescale9 okay one more time. Landed another fix |
ychescale9
force-pushed
the
yc/add-apple-silicon-targets
branch
from
b3d2fd6 to
95522dc
Compare
|
Done |
benasher44
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or Changes Proposed
PR Checklist