Fixed JVM UUID String Parsing #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fleshgrinder
added
bug
benasher44
reviewed
Feb 16, 2020
Fleshgrinder
force-pushed
the
uuid-string-parsing
branch
from
44a0b1a
to
f6718ef
Compare
Fleshgrinder
force-pushed
the
uuid-string-parsing
branch
from
ecb3f36
to
c5b8199
Compare
benasher44
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.util.UUID.fromStringis broken in all Java releases (so far) and allows the construction of UUIDs from strings that are not RFC compliant. This implementation is faster than the Java implementation on all releases and correct.