Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Page flashes when navigating to base URL #2735

Closed
NickersWeb opened this issue May 13, 2021 · 3 comments · Fixed by #2748
Closed

Login Page flashes when navigating to base URL #2735

NickersWeb opened this issue May 13, 2021 · 3 comments · Fixed by #2748
Labels
bug Something isn't working expected-behavior-but-awkward-and-could-get-rework

Comments

@NickersWeb
Copy link
Contributor

Describe the bug
When logged in and navigating to the base url e.g. "https://dogehouse.tv/", the login screen flashes for a split second.
Potentially not handling authenticated users and seem to navigate away from login screen.

To Reproduce
Steps to reproduce the behavior:

  1. navigate to base url when logged in.
  2. See login page flash before navigating to dash.

Expected behavior
Authenticated uses should automatically be on dash from root.
React Route for "/" && "/dash" should be the same.

Screenshots
Have video if required.

What device are you on?
Windows 10 PC Edge Browser
@NickersWeb NickersWeb added the bug Something isn't working label May 13, 2021
@NickersWeb NickersWeb changed the title Login Page flashes when navigating to route URL Login Page flashes when navigating to base URL May 13, 2021
@samarmohan
Copy link
Contributor

Yeah, that is expected. We can't really do anything because the login screen needs to recognize the tokens, can't stop that from happening.

@NickersWeb
Copy link
Contributor Author

Is this a related issue with oauth then?

@samarmohan
Copy link
Contributor

It is not an issue. It's probably expected-behavior-but-awkward-and-could-get-rework

sahilmob added a commit to sahilmob/dogehouse that referenced this issue May 13, 2021
@sahilmob
fix(kibbeh): prevent login screen from rendering if tokens is not yet…
77aded8 
… checked

fix benawad#2735
@sahilmob sahilmob mentioned this issue May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working expected-behavior-but-awkward-and-could-get-rework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kibbeh): prevent login screen from rendering if tokens is not yet checked sahilmob/dogehouse
3 participants
@NickersWeb @amitojsingh366 @samarmohan