fix(kibbeh): add top padding to banned users #2759
Conversation
Signed-off-by: Odyssey346 <odyssey346@disroot.org>
|
This pull request is being automatically deployed with Vercel (learn more). staging – ./kibbeh🔍 Inspect: https://vercel.com/dogehouse-staging/staging/9GzVz9wRbEuPMwcEL9v88P6fhghD dogehouse – ./kibbeh🔍 Inspect: https://vercel.com/benawad/dogehouse/7uYpBmL1FyxPWzZCXr7tAQgYqfZv storybook – ./kibbeh🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/AbZvViQW3DQbrYEjAYKFpTARmHFW [Deployment for c789921 canceled] |
|
Shouldn't the padding between each of the group be consistent, by a group I mean label and field? Edit: Just noticed you used css styling to add padding, wouldn't it be better to stick to tailwind css for the sake of consistency? |
|
i've seen a couple of components do this way, i dont think theres gonna be multiple things using the exact same padding as this one |
|
also im not exactly sure what you meant with the padding thing |
|
What I meant is, the space between each of the fields should all be same. Like the space between the first checkbox and chat cool down label, the bottom of the field and chat label and then again bottom of the field and Banned users label. |
|
Oh yeah, it's definitely inconsistent. I see what you mean. |
Signed-off-by: Oxygemo <alej0hio2007@gmail.com>
|
I didn't see that before le commit.... Crap. |
Just change it to be responsive |
|
Ofcourse, but my mom is making me go to bed at 9pm in a fucking weekend. Can't do it tomorrow either apparently because I've been "not listening to her for the past week" |
|
So I can't at the moment. Will do tomorrow. |
👍 |
| @@ -122,7 +122,7 @@ export const BlockedFromRoomUsers: React.FC<BlockedFromRoomUsersProps> = ({}) => | |||
|
|
|||
| return ( | |||
| <> | |||
| <div className={`flex mt-4 flex-col text-primary-100`}> | |||
| <div style={{ paddingTop: "15px"}} className={`flex mt-4 flex-col text-primary-100`}> | |||
There was a problem hiding this comment.
use tailwind classes not custom styles
Signed-off-by: Oxygemo <alej0hio2007@gmail.com>
|
aaaaaaaaaaaaaaaaaaaaaaaaaaaa |
Signed-off-by: Oxygemo <alej0hio2007@gmail.com>
|
I believe I've done both of your suggestions. |
This adds padding to banned users, because it looks awkwardly placed with the chat mode selector.
Before:
After:
Signed-off-by: Odyssey346 odyssey346@disroot.org