Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kibbeh): add more Linux platforms to download #2765

Merged
merged 3 commits into from
May 15, 2021
Merged

fix(kibbeh): add more Linux platforms to download #2765

merged 3 commits into from
May 15, 2021

Conversation

pistasjis
Copy link
Contributor

Signed-off-by: Oxygemo alej0hio2007@gmail.com

Signed-off-by: Oxygemo <alej0hio2007@gmail.com>
@vercel
Copy link

vercel bot commented May 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dogehouse – ./kibbeh

🔍 Inspect: https://vercel.com/benawad/dogehouse/44G5uFDPPohAU2HUhhURLLTCjMBt
✅ Preview: https://dogehouse-git-fork-odyssey346-add-more-linux-plats-benawad.vercel.app

storybook – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/8Gp3Qn4c6WSqLG8mxdmMKksycpL5
✅ Preview: Canceled

[Deployment for 13594e4 canceled]

staging – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-staging/staging/GNgiH4dBRVSMb5dvod248TnQf8Vh
✅ Preview: https://staging-git-fork-odyssey346-add-more-linux-plats-deb584.vercel.app

@pistasjis
Copy link
Contributor Author

image

@github-actions github-actions bot added the kibbeh Related to the UI design implementation label May 15, 2021
Signed-off-by: Oxygemo <alej0hio2007@gmail.com>
@pistasjis
Copy link
Contributor Author

Always has been

@pistasjis
Copy link
Contributor Author

I will try to fix the downloads page in this PR from now on. Kinda hate changing the scope of a PR but meh

@pistasjis pistasjis changed the title fix(kibbeh): add more Linux platforms to download fix(kibbeh): improve download page May 15, 2021
@BronzW
Copy link
Contributor

BronzW commented May 15, 2021

You could take inspiration from the discord download page
image

@pistasjis
Copy link
Contributor Author

That's what I'm planning to do. I'll most likely make a dropdown for Linux downloads instead of having a bazillion buttons for each way of packaging.

@pistasjis
Copy link
Contributor Author

nvm will do that in a later pr. pls merge

@samarmohan
Copy link
Contributor

You could take inspiration from the discord download page
image

@ajmnz has to approve new design thingies.

@ajmnz
Copy link
Contributor

ajmnz commented May 15, 2021

@ajmnz has to approve new design thingies.

I didn't even get to design it, so no worries for now

@amitojsingh366
Copy link
Contributor

You could take inspiration from the discord download page
image

no, don't do that. we will redesign when @ajmnz comes up with a design for this

@amitojsingh366 amitojsingh366 changed the title fix(kibbeh): improve download page fix(kibbeh): add more Linux platforms to download May 15, 2021
@pistasjis
Copy link
Contributor Author

fix the eslint error please
how the hell did that happen

Signed-off-by: Oxygemo <alej0hio2007@gmail.com>
@laurens-vrh
Copy link
Contributor

laurens-vrh commented May 15, 2021

Maybe just add a dropdown for all the Linux ones for now, and improve the design later ?

Edit: minor detail; but when you hover over the Dogehouse logo, there's no cursor pointer

@pistasjis
Copy link
Contributor Author

don't feel like doing that atm, but i'll do it in another pr

@overlisted overlisted merged commit 2e72f41 into benawad:staging May 15, 2021
@pistasjis pistasjis deleted the add-more-linux-plats branch May 15, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kibbeh Related to the UI design implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants