Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kibbeh): update Indonesian 1/x #2813

Merged
merged 7 commits into from
May 18, 2021
Merged

fix(kibbeh): update Indonesian 1/x #2813

merged 7 commits into from
May 18, 2021

Conversation

s3ansh33p
Copy link
Contributor

More changes to be added in this pr, i'll comment when I have done all of them

@s3ansh33p
fix(kibbeh): update Indonesian 1/x
b718b74 
More changes to be added in this pr, i'll comment when I have done all of them
@vercel
Copy link

vercel bot commented May 18, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

staging – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-staging/staging/G9vp7nhwUxBi1jkeVGgbvoPcX4dJ
✅ Preview: Failed

[Deployment for 61d754f failed]

dogehouse – ./kibbeh

🔍 Inspect: https://vercel.com/benawad/dogehouse/9PWYeHd2TwHNTpvKG6EkKDtf9gV9
✅ Preview: https://dogehouse-git-fork-s3ansh33p-patch-2-benawad.vercel.app

storybook – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/DBF92gtCjt5bo15mwfrGFF9vJvpG
✅ Preview: Canceled

[Deployment for 61d754f canceled]

@vercel
Copy link

vercel bot commented May 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/DBF92gtCjt5bo15mwfrGFF9vJvpG
✅ Preview: In Progress

@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 02:18 Inactive
@github-actions github-actions bot added kibbeh Related to the UI design implementation translation Issues or pull requests related to translations labels May 18, 2021
@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 03:15 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 03:34 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 04:10 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 04:13 Inactive
@s3ansh33p
Copy link
Contributor Author

Should be ready to push

MeztliRA
MeztliRA reviewed May 18, 2021
View reviewed changes
kibbeh/public/locales/id/translation.json
"username": "Username",
"usrStaff": "User Staff",
"usrContributions": "User Contributions",
"userStaffandContrib": "Kontrubsi pengguna & staf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"userStaffandContrib": "Kontrubsi pengguna & staf",
"userStaffandContrib": "Kontribusi pengguna & staf",

fix the typo

kibbeh/public/locales/id/translation.json Outdated Show resolved Hide resolved
kibbeh/public/locales/id/translation.json Outdated Show resolved Hide resolved
@s3ansh33p @MeztliRA
fix(kibbeh): update Indonesian 1/2 suggestion
249431a 
Co-authored-by: MeztliRA <78863518+MeztliRA@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 05:46 Inactive
@s3ansh33p @MeztliRA
fix(kibbeh): update Indonesian 2/2 suggestion
61d754f 
Co-authored-by: MeztliRA <78863518+MeztliRA@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – storybook May 18, 2021 05:47 Inactive
@dk-raw dk-raw merged commit 6fe9cc4 into benawad:staging May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeztliRA MeztliRA MeztliRA left review comments

Assignees
No one assigned
Labels
kibbeh Related to the UI design implementation translation Issues or pull requests related to translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s3ansh33p @MeztliRA @dk-raw