Adding support for HTTP basic auth #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbalter
reviewed
Jul 31, 2017
lib/sitemap-parser.rb
Outdated
| if @options[:userpwd] | ||
| request_options[:userpwd] = @options[:userpwd] | ||
| end | ||
| request = Typhoeus::Request.new(@url, request_options) |
There was a problem hiding this comment.
Would it make sense to simply pass @options to Typhoeus to support all Typhoeus options?
There was a problem hiding this comment.
The only reason I did not do so is because :recurse is not an option we'd want to hand to Typhoeus
There was a problem hiding this comment.
Should we delete decurse before passing then and pass the rest? (Blacklist, rather than whitelist?)
|
Nice! Thanks @trumant! Will work on getting a new release out with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.