Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrections in readme like spelling #425

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

jatin-code21
Copy link
Contributor

@jatin-code21 jatin-code21 commented Oct 18, 2022

No description provided.

@SoftCreatR
Copy link
Collaborator

@benbarth

@benbarth
Copy link
Owner

Hi @jatin-code21, please discuss changes to the README with a maintainer before making a PR. More details can be found in our contributing guide. I'll accept the change from incentivise to incentivize. The other changes aren't necessary. The label case doesn't really matter but labels are typically lowercase. The most common format of "open source" has no dash as discussed on the Wikipedia page.

@jatin-code21
Copy link
Contributor Author

Hi @jatin-code21, please discuss changes to the README with a maintainer before making a PR. More details can be found in our contributing guide. I'll accept the change from incentivise to incentivize. The other changes aren't necessary. The label case doesn't really matter but labels are typically lowercase. The most common format of "open source" has no dash as discussed on the Wikipedia page.

ok sure, will keep it in mind for next time. Thanks for the knowledge.

@jatin-code21
Copy link
Contributor Author

Please can you guide me on where to discuss the changes to be made?

If it is here only then, I want to make a PR for changing the incentivise to incentivize in the readme.md.
Thank You.

@SoftCreatR SoftCreatR merged commit b4bd338 into benbarth:master Oct 19, 2022
@vimode
Copy link
Contributor

vimode commented Oct 19, 2022

@jatin-code21 Its generally a good idea to first open an issue to discuss this way you only work on whats approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants