Verified Parity with 2019 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now there is no conflict |
Closed
|
As @benbarth already pointed out here and here there is already a swag bag icon he'd prefer you to use. Please stick to the /icons/ folder. This PR still has you uploading Please take the time to choose 1 PR (preferably this one) that has everything fully aligned with the existing formatting of the rest of the repo and follow the instructions provided by the repo maintainers. |
|
@crweiner I have made the final changes in the last update with |
|
Hi @Ishaan28malik, your PR still has the shopping-bag.png. Could you remove it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Parity to the list, Earlier PR got some error