Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization for SemanticSplitRange searching #219

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Conversation

benbrandt
Copy link
Owner

Leverages the fact that these ranges are guaranteed to be sorted now. Rather than doing a retain, which likely moves items in the vec and also has to iterate over all values, instead there is a cursor to extract the desired slice, and we can move the cursor to the first item that would still be in the range we desire.

Leverages the fact that these ranges are guaranteed to be sorted now. Rather than doing a retain, which likely moves items in the vec and also has to iterate over all values, instead there is a cursor to extract the desired slice, and we can move the cursor to the first item that would still be in the range we desire.
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.65%. Comparing base (ac9f17a) to head (d99387e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          11       11           
  Lines        2036     2047   +11     
=======================================
+ Hits         2029     2040   +11     
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbrandt benbrandt merged commit 1eecfda into main Jun 8, 2024
24 checks passed
@benbrandt benbrandt deleted the range-optimization branch June 8, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant