Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support references to tokenizers #37

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Support references to tokenizers #37

merged 1 commit into from
Aug 10, 2023

Conversation

benbrandt
Copy link
Owner

Support passing tokenizers for Huggingface and Tiktoken by reference instead of by value.

@benbrandt benbrandt marked this pull request as ready for review August 10, 2023 18:59
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (1b36cac) 97.57% compared to head (c985087) 97.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   97.57%   97.63%   +0.05%     
==========================================
  Files           4        4              
  Lines         537      550      +13     
==========================================
+ Hits          524      537      +13     
  Misses         13       13              
Files Changed Coverage Δ
src/huggingface.rs 100.00% <100.00%> (ø)
src/tiktoken.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbrandt benbrandt merged commit 2af8bd8 into main Aug 10, 2023
@benbrandt benbrandt deleted the support-references branch August 10, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant