Merge pull request hashicorp#10849 from benbuzbee/benbuz/fix-destroy

Don't treat a failed recover + successful destroy as a successful recover
benbuzbee · Jul 28, 2021 · a337fe0 · a337fe0
1 parent 831fc02
commit a337fe0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.changelog/10849.txt b/.changelog/10849.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+drivers: Fixed bug where Nomad incorrectly reported tasks as recovered successfully even when they were not.
+```
diff --git a/client/allocrunner/taskrunner/task_runner.go b/client/allocrunner/taskrunner/task_runner.go
@@ -1079,10 +1079,9 @@ func (tr *TaskRunner) restoreHandle(taskHandle *drivers.TaskHandle, net *drivers
 					"error", err, "task_id", taskHandle.Config.ID)
 			}
 
-			return false
 		}
 
-		return true
+		return false
 	}
 
 	// Update driver handle on task runner