Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collectors must Respond with JSON #85

Open
VincenzoFerme opened this issue Aug 20, 2016 · 0 comments
Open

Collectors must Respond with JSON #85

VincenzoFerme opened this issue Aug 20, 2016 · 0 comments
Assignees
Milestone

Comments

@VincenzoFerme
Copy link
Member

VincenzoFerme commented Aug 20, 2016

Apply the same improvement applied for the monitors so that all the responses to client are in structured JSON objects, where the structure should be placed in the commons package to the collectors. The structure can simply be:

{
   status: "SUCCESS" or "FAILED"
   message: "..."
}

Of course the same information should be printed on the standard output of the collectors. This applies to all the collectors, because everything must be logged and the client should be aware about what happens in the collectors.

Start from the changes made in #89 and improve the error handling, the structure of the returned message, the use of http errors in case of internal error and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants