Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using JSON responses, reenabled mysqldump for sql dumps #89

Merged
merged 2 commits into from
Aug 23, 2016
Merged

Using JSON responses, reenabled mysqldump for sql dumps #89

merged 2 commits into from
Aug 23, 2016

Conversation

Cerfoglg
Copy link
Contributor

@Cerfoglg Cerfoglg commented Aug 22, 2016 •
edited by VincenzoFerme
Loading

Fixes #83
Improves #85


  

VincenzoFerme
VincenzoFerme reviewed Aug 23, 2016
View reviewed changes
dbms/mysql/src/cloud/benchflow/collectors/mysql.go
minio.GzipFile("/app/"+os.Getenv("MYSQL_DB_NAME")+"_backup.sql")
minio.SendGzipToMinio("/app/"+os.Getenv("MYSQL_DB_NAME")+"_backup.sql.gz", os.Getenv("MINIO_HOST"), os.Getenv("MINIO_PORT"), databaseMinioKey+"/"+os.Getenv("MYSQL_DB_NAME")+"_backup.sql", os.Getenv("MINIO_ACCESSKEYID"), os.Getenv("MINIO_SECRETACCESSKEY"))

err = os.Remove("/app/"+os.Getenv("MYSQL_DB_NAME")+"_backup.sql.gz")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not removing the sql file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincenzoFerme When you gzip something it overwirtes the uncompressed file, so I only have to remove the gzipped file because that's all there is.

@VincenzoFerme
Copy link
Member

Missing from #85:

  • The structure of the response is not as described. Moreover it should be placed in commons.
  • Of course the same information should be printed on the standard output of the collectors

@VincenzoFerme VincenzoFerme added this to the Priorities milestone Aug 23, 2016
@Cerfoglg
Copy link
Contributor Author

@VincenzoFerme Altered the structure to fit the issue description

@VincenzoFerme VincenzoFerme mentioned this pull request Aug 23, 2016
Open
@VincenzoFerme VincenzoFerme merged commit 382ce3f into benchflow:dev Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cerfoglg Cerfoglg

Labels
enhancement
Milestone
Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@Cerfoglg @VincenzoFerme