Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ndjson benchmark output #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregtatum
Copy link

At unicode-org/icu4x#446 I'm working on adding memory benchmarks to the ICU4X project. This PR contains the necessary code to add support for ndjson, a newline delimited json format that is friendly to CI and appending data to.

This code includes tests, and basic support, but does not include an example. If this PR is accepted, I can follow-up with adding an example as well.

@gnrunge
Copy link

gnrunge commented Mar 18, 2022

This PR is most useful and used already by at least two GitHub repositories. Can someone with merge authorities please take a look?
BTW, the landing page of the failing codecov/project/ returns 404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants