Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/manual and scheduled runs #74

Merged
merged 7 commits into from
Oct 12, 2021

Conversation

ktrz
Copy link
Member

@ktrz ktrz commented Aug 11, 2021

resolve #24
resolve #73

If there are not head_commit nor pull_request data in the action payload I've added a fallback to fetch the data about the current commit via GitHub REST API

@ktrz
Copy link
Member Author

ktrz commented Aug 13, 2021

Hello @rhysd
Could you please approve running the workflow?

@maximiliancsuk
Copy link

Would <3 if this gets merged too as I'm also having issue #73

@NathanielRN
Copy link
Contributor

Thanks for this change! I made some edits that I think would be useful in this PR on your fork: ktrz#1.

@rhysd we're using my changes successfully on our scheduled: + workflow_dispatch: workflow which publish benchmarks to hopefully help as confirmation that this PR does we intend 🙂 The tests all use the github.context.repo object now instead of github.context.payload.repository so I didn't see it necessary to add additional tests.

@NathanielRN
Copy link
Contributor

@rhysd Just trying to catch your attention now that I've seen you working on this repo! This change is tested to work for schedule: and workflow_dispatch: runs.

If you think it looks good could we merge it in? Please let us know if you have any questions!

@ktrz ktrz merged commit 14b2070 into benchmark-action:master Oct 12, 2021
@ktrz ktrz deleted the fix/manual-and-scheduled-runs branch October 12, 2021 19:30
@ktrz
Copy link
Member Author

ktrz commented Oct 12, 2021

hi @NathanielRN
Thanks for pinging this issue. I've merged this PR and released a new version v1.9.0. The new changes should be available on the v1 version of the action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When running workflow with workflow_dispatch the action fails Workflow fails on cron jobs
3 participants