Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snapml solver #25

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Add snapml solver #25

merged 3 commits into from
Mar 29, 2022

Conversation

tanglef
Copy link
Member

@tanglef tanglef commented Mar 25, 2022

Fixes #24 by adding the snapml solver.

Also linked to benchopt/benchmark_logreg_l1#20 issue with OMP_NUM_THREADS=1.

agramfort
agramfort approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming plots look good !

thx @tanglef

@mathurinm mathurinm closed this Mar 29, 2022
@mathurinm mathurinm reopened this Mar 29, 2022
@tanglef
Copy link
Member Author

tanglef commented Mar 29, 2022

I've shared some plots in the discussion about the L1 penalty here. And they seem to look good

@mathurinm mathurinm merged commit 120e6a7 into benchopt:main Mar 29, 2022
@mathurinm
Copy link
Contributor

Thank you @tanglef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agramfort agramfort agramfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add snapml solver
3 participants
@tanglef @mathurinm @agramfort