Make categories sorted from largest (bottom of the graph) to smallest (top). #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! I could go either way on including the recent year's total. Also, what do you think about the cursor hovering behavior? By default it shows all values which is nice on desktop but kind of annoying on mobile. "Show closest data on hover" might be easier. |
|
@bendnorman The hover behavior is bit busy on mobile, but I personally like it. I think it's pretty important to be able to get specifics (it'd be pretty hard to click on the small categories - although maybe it'd be sufficient to know they were small). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make categories sorted from largest (bottom of the graph) to smallest (top).