Extend configuration to include colors and fonts #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yefimtsev
changed the title
* Add Colors struct to the configuration to handle color customization of the buttons, instruction and background * Add Fonts struct to the configuration to handle font customization of the buttons and instruction * Remove hardcoded color and font references in CropView * Fix trailing whitespaces in CropView.swift
yefimtsev
force-pushed
the
ui-customization
branch
from
3055d0b to
22ed64a
Compare
benedom
approved these changes
Oct 21, 2024
|
Hey @yefimtsev thanks for the improvements! I adjusted a bit of your code, please check if this works for you! If yes, I will merge and create a new release :) |
|
Looks good to me, @benedom :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the library, @benedom!
After integrating it into my project, I realized that I’d really like the ability to customize the hardcoded design to better fit the existing styles in my project.
To avoid overengineering, I extended the approach used for customTexts, though I made slight changes to the naming. In this implementation, both fonts and colors are always fetched from the configuration.
Looking forward to your feedback!