Refactor sqlite #16
Merged
Refactor sqlite #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to push commits into an active review! I promise I'm walking away for a bit now. :) |
|
Don't ever be sorry about pushing commits. |
fonji
reviewed
Feb 2, 2022
Comment on lines
+161
to
+162
| "VALUES (?, ?, ?, ?);", | ||
| episode.episodeId, selectedAuthor.authorId, |
There was a problem hiding this comment.
is the ? trick enough to sanitize user inputs?
As the discord members like silliness, and XKCD, we don't want to run into a "little Bobby tables" suggestion
There was a problem hiding this comment.
Though, A) I'm trusting this ticket, B) I absolutely need to include a Little Bobby Tables Easter egg into this thing at some point.
There was a problem hiding this comment.
Cool! I think you can trust it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fonji, can you take a look at this before I do any more work? There's some optimization left to do at the top of the file, but I'm mostly worried about the actual DB interfaces that get exported. Everything looks about as clean as it can get to me, but I'd like your opinion.