-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function to make top-k recommendations to all users in a fast way for ALS model. #179
Conversation
modified: implicit/evaluation.cpp modified: implicit/evaluation.pyx new file: implicit/topnc.cpp new file: implicit/topnc.h modified: setup.py Function to make top-k recommendations to all users in a fast way. Doesn't have "exclude already liked items" functionality yet.
Filter already liked items from recommendations before selecting top@k.
Added docstring and comments
I'll check the code soon... |
I briefly checked the code(I didn't understand the detail of cython code) but (It's totally my opinion) (1) This function is very helpful for both actual recommendation and evaluation. I think it should be a method of MatrixFactorizationBase because BPR model also generates exactly the same way as ALS does. implicit/implicit/recommender_base.py Line 128 in 94e4e7c
|
Oh, I've just seen that the owner wants it to be in |
We don't have evaluation.py yet, but we have evaluation.pyx instead) |
That's not the point btw. Anyway, could you please consider moving that function into the method of MatrixFactorizationBase? |
one last thing... |
1. Recommend will filter items like default method. 2. C++ types strike back. Fix in batch calculation. 3. Moved unit test to proper place.
Thanks!! |
Function to make top-k recommendations to all users in a fast way for ALS model. Main feature is custom C++ argsort for numpy 2d ndarray that runs in parallel.
For users_items == ~11kk x 130k it requires ~45 minutes to evaluate on 80-CPU server and is 10-20 times faster than looping model.recommend. I think it closes #29 and #72 . May be it can be improved by ideas from #126.
Please feel free to criticise. I can move it anywhere in code to be more consistent from your point of view with the library structure.