Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell completion generation broken in 0.3.13 #520

Closed
max-ae opened this issue Sep 5, 2022 · 2 comments · Fixed by #522
Closed

Shell completion generation broken in 0.3.13 #520

max-ae opened this issue Sep 5, 2022 · 2 comments · Fixed by #522

Comments

@max-ae
Copy link

max-ae commented Sep 5, 2022

bfbb9a9 most likely broke shell completions.

❯ py-spy completions fish
thread 'main' panicked at 'Must use `_os` lookups with `Arg::allow_invalid_utf8` at `[hash: EFB57B56EBBA4CFA]`', /Users/runner/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/clap-3.2.15/src/parser/matches/arg_matches.rs:1707:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
❯ py-spy completions zsh
thread 'main' panicked at 'Must use `_os` lookups with `Arg::allow_invalid_utf8` at `[hash: EFB57B56EBBA4CFA]`', /Users/runner/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/clap-3.2.15/src/parser/matches/arg_matches.rs:1707:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
❯ py-spy completions bash
thread 'main' panicked at 'Must use `_os` lookups with `Arg::allow_invalid_utf8` at `[hash: EFB57B56EBBA4CFA]`', /Users/runner/.cargo/registry/src/git.luolix.top-1ecc6299db9ec823/clap-3.2.15/src/parser/matches/arg_matches.rs:1707:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
@max-ae max-ae mentioned this issue Sep 5, 2022
Closed
benfred added a commit that referenced this issue Sep 7, 2022
@benfred
Fix shell completions
8d7ac06 
We had a panic happen on running `py-spy completions bash`, due
to clap-rs/clap#3826 .

Fixes #520
@benfred benfred mentioned this issue Sep 7, 2022
Merged
@benfred
Copy link
Owner

benfred commented Sep 7, 2022

Thanks for the bug report @max-ae - I've managed to reproduce, and have a fix in #522. I'll push out a new version with the fix sometime today

benfred added a commit that referenced this issue Sep 7, 2022
@benfred
Fix shell completions (#522)
0290978 
We had a panic happen on running `py-spy completions bash`, due
to clap-rs/clap#3826 .

Fixes #520
@benfred
Copy link
Owner

benfred commented Sep 7, 2022 •
edited
Loading

Fix will be in v0.3.14 - which will be pushed out to pypi/crates.io by CI once this finishes https://github.com/benfred/py-spy/actions/runs/3010745057 in about 30 minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shell completions benfred/py-spy
2 participants
@benfred @max-ae